Issue 3046023: Create factories for policy pref stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3046023: Create factories for policy pref stores. (Closed)

Created:
10 years, 5 months ago by Mattias Nissler (ping if slow)

Modified:
9 years, 7 months ago

Reviewers:
danno

CC:
chromium-reviews, ben+cc_chromium.org, markusheintz_, gfeher.google, Pam (message me for reviews)

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Create factories for policy pref stores. BUG=None TEST=Tests that use a regular PrefService are green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53770

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -47 lines)			Patch
M	chrome/browser/configuration_policy_pref_store.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/configuration_policy_pref_store.cc	View	1 2	2 chunks	+52 lines, -0 lines	0 comments	Download
M	chrome/browser/pref_service.cc	View	1	3 chunks	+2 lines, -47 lines	0 comments	Download

Total messages: 2 (0 generated)

Mattias Nissler (ping if slow)

Is this what we want? A small step in the right direction, that is? ;)

10 years, 5 months ago (2010-07-26 14:38:32 UTC) #1

LGTM!