Issue 3046019: Exclude ResourceDispatcherHost.Cancel from valgrind test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3046019: Exclude ResourceDispatcherHost.Cancel from valgrind test (Closed)

Created:
10 years, 5 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, stuartmorgan, Timur Iskhodzhanov, Alexander Potapenko, Paweł Hajdan Jr.

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Exclude ResourceDispatcherHost.Cancel This is same cause as 50002. TBR=darin@chromium.org BUG=50002 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53555

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/test/data/valgrind/unit_tests.gtest_mac.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

10 years, 5 months ago (2010-07-26 16:59:34 UTC) #2

OK

On Fri, Jul 23, 2010 at 5:20 PM, <oshima@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Exclude ResourceDispatcherHost.Cancel
>  This is same cause as 50002.
>
> TBR=darin@chromium.org
> BUG=50002
> TEST=none
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53555
>
> Please review this at http://codereview.chromium.org/3046019/show
>
> SVN Base: git://git.chromium.org/chromium.git
>
> Affected files:
>  M chrome/test/data/valgrind/unit_tests.gtest_mac.txt
>
>
> Index: chrome/test/data/valgrind/unit_tests.gtest_mac.txt
> diff --git a/chrome/test/data/valgrind/unit_tests.gtest_mac.txt
> b/chrome/test/data/valgrind/unit_tests.gtest_mac.txt
> index
>
a6fddc8ffd37e354c29a00c4f2078d027e78a9b9..3915d9a5546596358377253bf98d8506c2695e04
> 100644
> --- a/chrome/test/data/valgrind/unit_tests.gtest_mac.txt
> +++ b/chrome/test/data/valgrind/unit_tests.gtest_mac.txt
> @@ -38,3 +38,5 @@ TabStripControllerTest.AddRemoveTabs
>  TaskManagerWindowControllerTest.*
>  # See http://crbug.com/50002.
>  ResourceDispatcherHostTest.TestMany
> +ResourceDispatcherHostTest.Cancel
> +
>
>
>

Expand Messages | Collapse Messages