Issue 3046003: Roll webkit 63575:63601

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3046003: Roll webkit 63575:63601 (Closed)

Created:
10 years, 5 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Stephen White, ojan

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Roll webkit 63575:63601 TBR=senorblanco,ojan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52793

Patch Set 1 #

Patch Set 2 : update expectations #

Patch Set 3 : 63601 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ojan

10 years, 5 months ago (2010-07-17 18:52:44 UTC) #2

LGTM

On Fri, Jul 16, 2010 at 6:07 PM, <tony@chromium.org> wrote:

> Reviewers: Stephen White, ojan,
>
> Description:
> Roll webkit 63575:63601
>
> TBR=senorblanco,ojan
>
> Please review this at http://codereview.chromium.org/3046003/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M DEPS
>  M webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index
>
2aba1552d0a8e9e0d0f9ccb3b3a67091df57afb8..11531fbf43685486eeed1424ae578db688334f36
> 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -1,7 +1,7 @@
>  vars = {
>   "webkit_trunk":
>   "http://svn.webkit.org/repository/webkit/trunk",
> -  "webkit_revision": "63575",
> +  "webkit_revision": "63601",
>   "ffmpeg_revision": "49485",
>   "skia_revision": "583",
>   "chromium_git": "http://src.chromium.org/git",
> Index: webkit/tools/layout_tests/test_expectations.txt
> diff --git a/webkit/tools/layout_tests/test_expectations.txt
> b/webkit/tools/layout_tests/test_expectations.txt
> index
>
f92a8ad613f198f0837803ad98eaa055f250c83b..bb6857e6918afff85123840554714ea6c59997cb
> 100644
> --- a/webkit/tools/layout_tests/test_expectations.txt
> +++ b/webkit/tools/layout_tests/test_expectations.txt
> @@ -21,7 +21,3 @@ BUG_TONYG MAC WIN : fast/dom/webtiming.html = TEXT
>  BUG_TONYG MAC WIN : http/tests/misc/webtiming-one-redirect.php = TEXT
>  BUG_TONYG MAC WIN : http/tests/misc/webtiming-two-redirects.php = TEXT
>  BUG_TONYG MAC WIN : fast/dom/Window/window-properties-performance.html =
> TEXT
> -
> -// TODO(ojan): Started failing during 63514:63575 roll.
> -BUG_OJAN WIN : inspector/console-trace.html = TEXT
> -BUG_OJAN LINUX MAC : svg/filters/filter-empty-g.svg = CRASH
>
>
>

Expand Messages | Collapse Messages