Issue 3045021: Fixing crash in buffer bar painting code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3045021: Fixing crash in buffer bar painting code (Closed)

Created:
10 years, 4 months ago by vrk (LEFT CHROMIUM)

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, scherkus (not reviewing), fbarchard, awong

Visibility:
Public.

Description

Fixing crash in buffer bar painting code Crash was because of inconsistent state caused by threading issues. The state of the buffer bar isn't so critical to need to be 100% accurate at all times, so this is fixed by capping the buffered_bytes_ and current_bytes to always be at legal values. BUG=49870 TEST=media_unittests TBR=hclam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54055

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	media/base/pipeline_impl.cc	View		2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages