Merge 53961 - [Mac] Fix the custom homepages preferences to:...

chrome/browser/cocoa/custom_home_pages_model_unittest.mm

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/scoped_nsobject.h"
 #include "chrome/browser/cocoa/browser_test_helper.h"
 #import "chrome/browser/cocoa/custom_home_pages_model.h"
+#include "chrome/browser/session_startup_pref.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 // A helper for KVO and NSNotifications. Makes a note that it's been called
 // back.
 @interface CustomHomePageHelper : NSObject {
  @public
   BOOL sawNotification_;
 }
 @end
 
 @implementation CustomHomePageHelper
 - (void)observeValueForKeyPath:(NSString*)keyPath
                       ofObject:(id)object
                         change:(NSDictionary*)change
                        context:(void*)context {
   sawNotification_ = YES;
 }
 
 - (void)entryChanged:(NSNotification*)notify {
   sawNotification_ = YES;
 }
 @end
 
+@interface NSObject ()
+- (void)setURL:(NSString*)url;
+@end
+
+namespace {
+
+// Helper that creates an autoreleased entry.
+CustomHomePageEntry* MakeEntry(NSString* url) {
+  CustomHomePageEntry* entry = [[[CustomHomePageEntry alloc] init] autorelease];
+  [entry setURL:url];
+  return entry;
+}
+
+// Helper that casts from |id| to the Entry type and returns the URL string.
+NSString* EntryURL(id entry) {
+  return [static_cast<CustomHomePageEntry*>(entry) URL];
+}
+
 class CustomHomePagesModelTest : public PlatformTest {
  public:
   CustomHomePagesModelTest() {
     model_.reset([[CustomHomePagesModel alloc]
                     initWithProfile:helper_.profile()]);
    }
   ~CustomHomePagesModelTest() { }
 
   BrowserTestHelper helper_;
   scoped_nsobject<CustomHomePagesModel> model_;
@@ skipping 29 matching lines @@
   [model_ setURLs:poorly_formed];
   received_urls = [model_.get() URLs];
   EXPECT_EQ(received_urls.size(), 2U);
 }
 
 // Test that we get a KVO notification when called setURLs.
 TEST_F(CustomHomePagesModelTest, KVOObserveWhenListChanges) {
   scoped_nsobject<CustomHomePageHelper> kvo_helper(
       [[CustomHomePageHelper alloc] init]);
   [model_ addObserver:kvo_helper
-          forKeyPath:@"customHomePages"
-             options:0L
-             context:NULL];
+           forKeyPath:@"customHomePages"
+              options:0L
+              context:NULL];
   EXPECT_FALSE(kvo_helper.get()->sawNotification_);
 
   std::vector<GURL> urls;
   urls.push_back(GURL("http://www.google.com"));
   [model_ setURLs:urls];  // Should send kvo change notification.
   EXPECT_TRUE(kvo_helper.get()->sawNotification_);
 
   [model_ removeObserver:kvo_helper forKeyPath:@"customHomePages"];
 }
 
 // Test the KVO "to-many" bindings for |customHomePages| and the KVO
 // notifiation when items are added to and removed from the list.
 TEST_F(CustomHomePagesModelTest, KVO) {
   EXPECT_EQ([model_ countOfCustomHomePages], 0U);
 
   scoped_nsobject<CustomHomePageHelper> kvo_helper(
       [[CustomHomePageHelper alloc] init]);
   [model_ addObserver:kvo_helper
-          forKeyPath:@"customHomePages"
-             options:0L
-             context:NULL];
+           forKeyPath:@"customHomePages"
+              options:0L
+              context:NULL];
   EXPECT_FALSE(kvo_helper.get()->sawNotification_);
 
   // Cheat and insert NSString objects into the array. As long as we don't
   // call -URLs, we'll be ok.
-  [model_ insertObject:@"www.google.com" inCustomHomePagesAtIndex:0];
+  [model_ insertObject:MakeEntry(@"www.google.com") inCustomHomePagesAtIndex:0];
   EXPECT_TRUE(kvo_helper.get()->sawNotification_);
-  [model_ insertObject:@"www.yahoo.com" inCustomHomePagesAtIndex:1];
-  [model_ insertObject:@"dev.chromium.org" inCustomHomePagesAtIndex:2];
+  [model_ insertObject:MakeEntry(@"www.yahoo.com") inCustomHomePagesAtIndex:1];
+  [model_ insertObject:MakeEntry(@"dev.chromium.org")
+      inCustomHomePagesAtIndex:2];
   EXPECT_EQ([model_ countOfCustomHomePages], 3U);
 
-  EXPECT_TRUE([[model_ objectInCustomHomePagesAtIndex:1]
-                  isEqualToString:@"www.yahoo.com"]);
+  EXPECT_TRUE([EntryURL([model_ objectInCustomHomePagesAtIndex:1])
+                  isEqualToString:@"http://www.yahoo.com/"]);
 
   kvo_helper.get()->sawNotification_ = NO;
   [model_ removeObjectFromCustomHomePagesAtIndex:1];
   EXPECT_TRUE(kvo_helper.get()->sawNotification_);
   EXPECT_EQ([model_ countOfCustomHomePages], 2U);
-  EXPECT_TRUE([[model_ objectInCustomHomePagesAtIndex:1]
-                  isEqualToString:@"dev.chromium.org"]);
-  EXPECT_TRUE([[model_ objectInCustomHomePagesAtIndex:0]
-                  isEqualToString:@"www.google.com"]);
+  EXPECT_TRUE([EntryURL([model_ objectInCustomHomePagesAtIndex:1])
+                  isEqualToString:@"http://dev.chromium.org/"]);
+  EXPECT_TRUE([EntryURL([model_ objectInCustomHomePagesAtIndex:0])
+                  isEqualToString:@"http://www.google.com/"]);
 
   [model_ removeObserver:kvo_helper forKeyPath:@"customHomePages"];
 }
 
-@interface NSObject()
-- (void)setURL:(NSString*)url;
-@end
-
 // Test that when individual items are changed that they broadcast a message.
 TEST_F(CustomHomePagesModelTest, ModelChangedNotification) {
   scoped_nsobject<CustomHomePageHelper> kvo_helper(
       [[CustomHomePageHelper alloc] init]);
   [[NSNotificationCenter defaultCenter]
       addObserver:kvo_helper
          selector:@selector(entryChanged:)
              name:kHomepageEntryChangedNotification
             object:nil];
 
   std::vector<GURL> urls;
   urls.push_back(GURL("http://www.google.com"));
   [model_ setURLs:urls];
   NSObject* entry = [model_ objectInCustomHomePagesAtIndex:0];
   [entry setURL:@"http://www.foo.bar"];
   EXPECT_TRUE(kvo_helper.get()->sawNotification_);
   [[NSNotificationCenter defaultCenter] removeObserver:kvo_helper];
 }
+
+TEST_F(CustomHomePagesModelTest, ReloadURLs) {
+  scoped_nsobject<CustomHomePageHelper> kvo_helper(
+      [[CustomHomePageHelper alloc] init]);
+  [model_ addObserver:kvo_helper
+           forKeyPath:@"customHomePages"
+              options:0L
+              context:NULL];
+  EXPECT_FALSE(kvo_helper.get()->sawNotification_);
+  EXPECT_EQ([model_ countOfCustomHomePages], 0U);
+
+  std::vector<GURL> urls;
+  urls.push_back(GURL("http://www.google.com"));
+  SessionStartupPref pref;
+  pref.urls = urls;
+  SessionStartupPref::SetStartupPref(helper_.profile(), pref);
+
+  [model_ reloadURLs];
+
+  EXPECT_TRUE(kvo_helper.get()->sawNotification_);
+  EXPECT_EQ([model_ countOfCustomHomePages], 1U);
+  EXPECT_TRUE([EntryURL([model_ objectInCustomHomePagesAtIndex:0])
+                  isEqualToString:@"http://www.google.com/"]);
+
+  [model_ removeObserver:kvo_helper.get() forKeyPath:@"customHomePages"];
+}
+
+}  // namespace