Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 3045003: Reapply r52859 (Closed)

Created:
10 years, 5 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
John Gregg
CC:
chromium-reviews, ben+cc_chromium.org
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Reapply r52859 This reverts commit a3d08737344176477998ba74549b3a23a72cdc96. This fix the win trybot by adding a missing ALLOW_THIS_IN_INITIALIZER_LIST macro necessary to silent the VS compiler. BUG=None TEST=trybots TBR=johnnyg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -136 lines) Patch
M chrome/browser/gtk/notifications/balloon_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/gtk/notifications/notification_options_menu_model.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/gtk/notifications/notification_options_menu_model.cc View 1 chunk +0 lines, -90 lines 0 comments Download
A chrome/browser/notifications/notification_options_menu_model.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_options_menu_model.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698