Issue 3044029: Hook up the new font API to WebKit. This moves the existing GetFontTable API ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3044029: Hook up the new font API to WebKit. This moves the existing GetFontTable API ... (Closed)

Created:
10 years, 4 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), sanjeevr

CC:
chromium-reviews, jam, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Hook up the new font API to WebKit. This moves the existing GetFontTable API to the private font interface. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54173

Patch Set 3 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+389 lines, -55 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_font.h	View	1 2	3 chunks	+22 lines, -6 lines	0 comments	Download
M	webkit/glue/plugins/pepper_font.cc	View	1 2	2 chunks	+233 lines, -47 lines	0 comments	Download
M	webkit/glue/plugins/pepper_private.cc	View	1 2	3 chunks	+73 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_resource.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_var.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/ppb_private.h	View	1 2	2 chunks	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Sanjeev: I moved the existing font thing you're using to the "Private" interface, and prefixed ...

10 years, 4 months ago (2010-07-27 23:24:32 UTC) #1

darin (slow to review)

LGTM http://codereview.chromium.org/3044029/diff/8001/9001 File webkit/glue/plugins/pepper_font.cc (right): http://codereview.chromium.org/3044029/diff/8001/9001#newcode179 webkit/glue/plugins/pepper_font.cc:179: font_.reset(WebFont::Create(web_font_desc)); WebFont::create ;-) http://codereview.chromium.org/3044029/diff/8001/9006 File webkit/glue/plugins/ppb_private.h (right): http://codereview.chromium.org/3044029/diff/8001/9006#newcode59 ...

10 years, 4 months ago (2010-07-28 00:03:40 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 3044029: Hook up the new font API to WebKit. This moves the existing GetFontTable API ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages