Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 3044001: Register getUserInfo message callback for register screen. (Closed)

Created:
10 years, 5 months ago by Nikita (slow)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org, dr, zel, arv (Not doing code reviews)
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Add getUserInfo, getRegistrationUrl message callback for register screen. Restrict chrome://register to OOBE wizard only. Actually delete about:register. BUG= http://crosbug.com/4813 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52902

Patch Set 1 #

Patch Set 2 : removed test changes #

Patch Set 3 : host page #

Patch Set 4 : more integration #

Total comments: 12

Patch Set 5 : merge #

Patch Set 6 : - test changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -20 lines) Patch
M chrome/browser/browser_about_handler.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/register_page_ui.cc View 1 2 3 4 5 4 chunks +105 lines, -2 lines 0 comments Download
M chrome/browser/resources/host_registration_page.html View 1 3 4 5 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
Now passing (some) system/user info to host registration page, registration form url. Next CL will ...
10 years, 5 months ago (2010-07-16 17:15:05 UTC) #1
whywhat
LGTM http://codereview.chromium.org/3044001/diff/6001/7002 File chrome/browser/chromeos/login/wizard_controller.cc (left): http://codereview.chromium.org/3044001/diff/6001/7002#oldcode21 chrome/browser/chromeos/login/wizard_controller.cc:21: #include "chrome/browser/chromeos/customization_document.h" I'd leave this here if the ...
10 years, 5 months ago (2010-07-16 17:27:35 UTC) #2
arv (Not doing code reviews)
FYI http://codereview.chromium.org/3044001/diff/6001/7006 File chrome/browser/resources/host_registration_page.html (right): http://codereview.chromium.org/3044001/diff/6001/7006#newcode11 chrome/browser/resources/host_registration_page.html:11: chrome.send('getRegistrationUrl', []); On 2010/07/16 17:27:37, whywhat wrote: > ...
10 years, 5 months ago (2010-07-16 17:47:28 UTC) #3
Nikita (slow)
10 years, 5 months ago (2010-07-19 11:46:24 UTC) #4
http://codereview.chromium.org/3044001/diff/6001/7002
File chrome/browser/chromeos/login/wizard_controller.cc (left):

http://codereview.chromium.org/3044001/diff/6001/7002#oldcode21
chrome/browser/chromeos/login/wizard_controller.cc:21: #include
"chrome/browser/chromeos/customization_document.h"
On 2010/07/16 17:27:37, whywhat wrote:
> I'd leave this here if the pointer is used here too.

Done.

http://codereview.chromium.org/3044001/diff/6001/7003
File chrome/browser/chromeos/login/wizard_controller.h (right):

http://codereview.chromium.org/3044001/diff/6001/7003#newcode12
chrome/browser/chromeos/login/wizard_controller.h:12: #include
"chrome/browser/chromeos/customization_document.h"
On 2010/07/16 17:27:37, whywhat wrote:
> Do we need this? I don't see any usage of the definition of the class, only
> passing pointers back and forth.

Done.

http://codereview.chromium.org/3044001/diff/6001/7005
File chrome/browser/dom_ui/register_page_ui.cc (right):

http://codereview.chromium.org/3044001/diff/6001/7005#newcode30
chrome/browser/dom_ui/register_page_ui.cc:30: const wchar_t kJSONOsName[] =
L"ChromeOS";
On 2010/07/16 17:27:37, whywhat wrote:
> Maybe kJsonOsName or kOSName?
> L"ChromiumOS"?

Done.

http://codereview.chromium.org/3044001/diff/6001/7005#newcode102
chrome/browser/dom_ui/register_page_ui.cc:102: if
(!WizardController::default_controller()) {
On 2010/07/16 17:27:37, whywhat wrote:
> This condition will be false also on login screen, not only during OOBE. Do we
> have is_oobe public method for controller to use?

Done.

http://codereview.chromium.org/3044001/diff/6001/7006
File chrome/browser/resources/host_registration_page.html (right):

http://codereview.chromium.org/3044001/diff/6001/7006#newcode24
chrome/browser/resources/host_registration_page.html:24:
chrome.send('getUserInfo', []);
On 2010/07/16 17:27:37, whywhat wrote:
> Ditto.

Not needed.

Powered by Google App Engine
This is Rietveld 408576698