Issue 3043011: build_image, build_kernel_image, update_bootloaders: fix up rootfs_verification

Issue 3043011: build_image, build_kernel_image, update_bootloaders: fix up rootfs_verification (Closed)

Created:
10 years, 5 months ago by Will Drewry

Modified:
10 years, 5 months ago

Reviewers:
Tan Gao, adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

build_image, build_kernel_image, update_bootloaders: fix up rootfs_verification This change adds - --rootfs_hash_pad to specify the MBs reserved for the pad - the implementation of the above flag - check if total fs size + pad size exceeds the partition size - hash appending in make_image_bootable() Fixes: - a style for ROOT_FS_HASH usage - bad mount|grep - bad bash subst for root devices in all boot paths - fixed a typo in the update_bootloaders table creation - disables verified usb for now Adding the padding argument ensures that the generated hash tree for the root filesystem is appended to the image. Assuming the rootfs is _never_ mounted read-write again, that hash tree will be valid and vboot will be able to proceed. BUG=chromium-os:2693 TEST=manual build_image

Patch Set 1 #

Patch Set 2 : fix bad mount|grep; fix bad device replacement in table #

Patch Set 3 : fix up a cut and paste typo in update_bootloaders #

Patch Set 4 : fix more subst errors; disable verified usb until we have initramfs or kernel supp #

Total comments: 4

Patch Set 5 : quick comment fix #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -19 lines)			Patch
M	build_image	View	1	6 chunks	+41 lines, -4 lines	0 comments	Download
M	build_kernel_image.sh	View	2 3	2 chunks	+4 lines, -5 lines	0 comments	Download
M	create_legacy_bootloader_templates.sh	View	4	1 chunk	+5 lines, -7 lines	0 comments	Download
M	update_bootloaders.sh	View	3	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

I added some tweaks for typos and simple bug fixes. PTAL!

10 years, 5 months ago (2010-07-21 15:31:48 UTC) #4

adlr

LGTM w/ comments http://codereview.chromium.org/3043011/diff/2003/13001 File build_image (right): http://codereview.chromium.org/3043011/diff/2003/13001#newcode97 build_image:97: if [ "$((FLAGS_rootfs_size + FLAGS_rootfs_hash_pad))" -gt ...

10 years, 5 months ago (2010-07-21 17:09:29 UTC) #5

Will Drewry

Thanks! http://codereview.chromium.org/3043011/diff/2003/13001 File build_image (right): http://codereview.chromium.org/3043011/diff/2003/13001#newcode97 build_image:97: if [ "$((FLAGS_rootfs_size + FLAGS_rootfs_hash_pad))" -gt \ On ...

10 years, 5 months ago (2010-07-21 17:15:02 UTC) #6

adlr

10 years, 5 months ago (2010-07-21 17:22:57 UTC) #7

ah, if they aren't needed, then i'm fine w/o the $s

On Wed, Jul 21, 2010 at 10:15 AM, <wad@chromium.org> wrote:

> Thanks!
>
>
>
> http://codereview.chromium.org/3043011/diff/2003/13001
> File build_image (right):
>
> http://codereview.chromium.org/3043011/diff/2003/13001#newcode97
> build_image:97: if [ "$((FLAGS_rootfs_size + FLAGS_rootfs_hash_pad))"
> -gt \
> On 2010/07/21 17:09:29, adlr wrote:
>
>> missing $s before the var names?
>>
>
> Do you want them?  $(()) resolves symbols without using $
>
>
> http://codereview.chromium.org/3043011/diff/2003/13001#newcode99
> build_image:99: error "rootfs ($((FLAGS_rootfs_size +
> FLAGS_rootfs_hash_pad)) MB) is \
> On 2010/07/21 17:09:29, adlr wrote:
>
>> same
>>
>
> ditto
>
>
> http://codereview.chromium.org/3043011/show
>

Expand Messages | Collapse Messages