Checking in CL http://www.codereview.chromium.org/2836058 on behalf of zbehan...

Checking in CL http://www.codereview.chromium.org/2836058 on behalf of zbehan@:


chrome: create an option for using libcros provided by the system; fix all
includes referring to libcros to not include third_party/

* Headers fix is needed to support using system libcros (installed to /usr/include)

* All includes are "", and therefore a local variant in third_party/cros/ is
always preferred, but system will also get picked up as a secondary target

* Fixed chrome/browser/chromeos/cros/synaptics_library.h comments to better
reflect the header placement

* Added a variable system_libcros defaulting to 0
* Gotten rid of duplicate cros_api.gyp
* Changed both places to either link against cros_api or libcrosapi

TEST=build in the following scenarios:
1) libcros not installed, libcros sources in third_party/, !defined system_libcros
- sucess
2) installed libcros, put #error into /usr/include/cros/chromeos_cros_api.h, repeat 1)
- success
3) BUILD_DEFINES+=system_libcros=1, removed libcros from third_party, repeat 2)
- fail (on #error in chromeos_cros_api.h)
4) Installed clean libcros, repeat 3)
- success


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53288

[zbehan, 2010-07-21 22:23:59]

http://codereview.chromium.org/3043010/diff/25002/19004
File chrome/browser/chromeos/DEPS (right):

http://codereview.chromium.org/3043010/diff/25002/19004#newcode2
chrome/browser/chromeos/DEPS:2: "+third_party/cros",
I believe that third_party/cros is not needed anymore. The patch should change
all of these, and in fact enforcement of _NOT_ allowing these would be
beneficial, as it will make sure noone will break the new way of including
libcros by accident.

[zel, 2010-07-21 22:28:26]

Actually, this is still needed for builds outside of chroot.

On Wed, Jul 21, 2010 at 3:24 PM, <zbehan@chromium.org> wrote:

>
> http://codereview.chromium.org/3043010/diff/25002/19004
> File chrome/browser/chromeos/DEPS (right):
>
> http://codereview.chromium.org/3043010/diff/25002/19004#newcode2
> chrome/browser/chromeos/DEPS:2: "+third_party/cros",
> I believe that third_party/cros is not needed anymore. The patch should
> change all of these, and in fact enforcement of _NOT_ allowing these
> would be beneficial, as it will make sure noone will break the new way
> of including libcros by accident.
>
> http://codereview.chromium.org/3043010/show
>