Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 3042009: Add --enable-device-orientation switch and set ENABLE_DEVICE_ORIENTATION=1 (Closed)

Created:
10 years, 5 months ago by hans
Modified:
9 years, 5 months ago
Reviewers:
bulach, jorlow
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add --enable-device-orientation switch and set ENABLE_DEVICE_ORIENTATION=1 Flip the compile-time enable switch for device orientation to on, and add a command-line switch to put the functionality behind. The command-line flag will be used both on the Chromium side, and in WebKit via WebRuntimeFeatures. BUG=44654 TEST=browser_tests --gtest_filter=DeviceOrientationEnableSwitchTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53317

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M build/features_override.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/device_orientation/enable_switch_browsertest.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/device_orientation/enable_switch_test.html View 1 chunk +32 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
hans
This CL depends on the patch in https://bugs.webkit.org/show_bug.cgi?id=42265.
10 years, 5 months ago (2010-07-20 14:07:34 UTC) #1
bulach
10 years, 5 months ago (2010-07-20 14:38:56 UTC) #2
LGTM

http://codereview.chromium.org/3042009/diff/1/9
File chrome/test/data/device_orientation/enable_switch_test.html (right):

http://codereview.chromium.org/3042009/diff/1/9#newcode10
chrome/test/data/device_orientation/enable_switch_test.html:10:
document.location = '#pass';
nice trick!

Powered by Google App Engine
This is Rietveld 408576698