AU: A basic framework for sending error events when update attempt fails.

AU: A basic framework for sending error events when update attempt fails.

Currently, only a generic kTypeUpdateComplete/kResultError/kActionCodeError
will be sent.

BUG=560
TEST=unit test, gmerged, forced updates, inspected logs.

[petkov, 2010-07-19 22:58:47]

Please take a look.

This could probably be somewhat simplified if we schedule the error event
directly inside ProcessingDone, however, there're a few downsides including some
difficulties with filtering or potentially customizing events based on which
action completed last.

We could do some of this by adding more status kinds but this will require
changes to libcros too, I guess.

Maybe I need to update libcros anyway, given that I've added this
UPDATE_STATUS_ERROR_EVENT?

[adlr, 2010-07-20 00:25:02]

LGTM w/ comment

http://codereview.chromium.org/3042007/diff/1/3
File update_attempter.h (right):

http://codereview.chromium.org/3042007/diff/1/3#newcode32
update_attempter.h:32: UPDATE_STATUS_ERROR_EVENT,
UPDATE_STATUS_REPORTING_ERROR_EVENT?

[petkov, 2010-07-20 00:35:16]

http://codereview.chromium.org/3042007/diff/1/3
File update_attempter.h (right):

http://codereview.chromium.org/3042007/diff/1/3#newcode32
update_attempter.h:32: UPDATE_STATUS_ERROR_EVENT,
On 2010/07/20 00:25:02, adlr wrote:
> UPDATE_STATUS_REPORTING_ERROR_EVENT?

I'll change. Does libcros need to be updated?

[adlr, 2010-07-20 00:39:28]

That's a value you just added, right? If you added it to libcros, you'll
need to update it there. It would be good to add it to libcros, tho, if you
haven't yet.

-andrew

On Mon, Jul 19, 2010 at 5:35 PM, <petkov@chromium.org> wrote:

>
> http://codereview.chromium.org/3042007/diff/1/3
> File update_attempter.h (right):
>
> http://codereview.chromium.org/3042007/diff/1/3#newcode32
> update_attempter.h:32: UPDATE_STATUS_ERROR_EVENT,
> On 2010/07/20 00:25:02, adlr wrote:
>
>> UPDATE_STATUS_REPORTING_ERROR_EVENT?
>>
>
> I'll change. Does libcros need to be updated?
>
>
> http://codereview.chromium.org/3042007/show
>

[petkov, 2010-07-20 16:23:12]

Pushing...

http://codereview.chromium.org/3042007/diff/1/3
File update_attempter.h (right):

http://codereview.chromium.org/3042007/diff/1/3#newcode32
update_attempter.h:32: UPDATE_STATUS_ERROR_EVENT,
On 2010/07/20 00:25:02, adlr wrote:
> UPDATE_STATUS_REPORTING_ERROR_EVENT?

Done.