Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 3042005: Relanding: Personal stuff page in tabbed options (Closed)

Created:
10 years, 5 months ago by sargrass
Modified:
9 years, 7 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org, dhg
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Relanding: Personal stuff page in tabbed options Relanding issue 2819046 BUG=48883 TEST=Exercise Personal Stuff page via --enable-tabbed-options Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53070

Patch Set 1 #

Patch Set 2 : Removed the include line of sync for chromeos only in options handler #

Patch Set 3 : chromeos / linux filter #

Patch Set 4 : chromeos linux filter #

Patch Set 5 : Chromeos linux filter #

Patch Set 6 : Chromeos linux filter #

Patch Set 7 : Filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -36 lines) Patch
M chrome/browser/dom_ui/options_ui.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/personal_options_handler.cc View 2 chunks +68 lines, -23 lines 0 comments Download
A + chrome/browser/dom_ui/sync_options_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/dom_ui/sync_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options.html View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
A chrome/browser/resources/options/personal_options.css View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/personal_options.html View 1 2 3 4 5 6 1 chunk +142 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/personal_options.js View 1 chunk +47 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/pref_ui.js View 1 chunk +52 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
csilv
10 years, 5 months ago (2010-07-20 17:46:14 UTC) #1
LGTM

(chromeOS issue resolved, ready to land this again.)

Powered by Google App Engine
This is Rietveld 408576698