Issue 3041045: Merge 54839 - [Mac] Adjust browser-action and content-setting popup points...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3041045: Merge 54839 - [Mac] Adjust browser-action and content-setting popup points... (Closed)

Created:
10 years, 4 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews, John Grabowski, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merge 54839 - [Mac] Adjust browser-action and content-setting popup points Adjust the browser-action popup point to leave the top border of the window 2px below the bottom border of the Omnibox. This matches the Omnibox popup, the bookmark popup, and page-action popups. Likewise content-setting popup. BUG=50575 TEST=The popup is spaced correctly. Review URL: http://codereview.chromium.org/3054040 TBR=shess@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54845

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -17 lines)			Patch
M	chrome/browser/cocoa/extensions/browser_actions_controller.mm	View	2 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/content_setting_decoration.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar/content_setting_decoration.mm	View	3 chunks	+18 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages