Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 3041045: Merge 54839 - [Mac] Adjust browser-action and content-setting popup points... (Closed)

Created:
10 years, 4 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews, John Grabowski, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Merge 54839 - [Mac] Adjust browser-action and content-setting popup points Adjust the browser-action popup point to leave the top border of the window 2px below the bottom border of the Omnibox. This matches the Omnibox popup, the bookmark popup, and page-action popups. Likewise content-setting popup. BUG=50575 TEST=The popup is spaced correctly. Review URL: http://codereview.chromium.org/3054040 TBR=shess@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -17 lines) Patch
M chrome/browser/cocoa/extensions/browser_actions_controller.mm View 2 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/cocoa/location_bar/content_setting_decoration.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/location_bar/content_setting_decoration.mm View 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Scott Hess - ex-Googler
10 years, 4 months ago (2010-08-03 23:46:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698