Don't schedule periodic update checks for non-official builds.

Don't schedule periodic update checks for non-official builds.

BUG=5334
TEST=unit tests, gmerged on device and tried with different tracks

[petkov, 2010-08-03 23:14:14]

For the unit test, I've basically copied the BootDeviceTest... :-/

[adlr, 2010-08-03 23:27:15]

http://codereview.chromium.org/3041044/diff/2001/3001
File main.cc (right):

http://codereview.chromium.org/3041044/diff/2001/3001#newcode57
main.cc:57: PeriodicallyUpdateArgs two_min_args = { update_attempter, FALSE };
should these not be on the stack if you're passing pointers to them around? you
could make them static

[petkov, 2010-08-03 23:44:47]

Thanks for the quick review. PTAL.

http://codereview.chromium.org/3041044/diff/2001/3001
File main.cc (right):

http://codereview.chromium.org/3041044/diff/2001/3001#newcode57
main.cc:57: PeriodicallyUpdateArgs two_min_args = { update_attempter, FALSE };
On 2010/08/03 23:27:15, adlr wrote:
> should these not be on the stack if you're passing pointers to them around?
you
> could make them static

Argh, thanks much for catching this! I guess I got unlucky and it just happened
to work rather than crash :-(

I've fixed it to avoid the argument storage. If you don't like that, I'd revert
to pretty much the original code and replace this routine with a simple
true/false ShouldSchedulePeriodicUpdates.

[adlr, 2010-08-03 23:56:48]

LGTM