Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7346)

Unified Diff: chrome/browser/views/tabs/tab.cc

Issue 3041006: Tweaks the pinned background tab title change animation per Nicholas's (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/multi_animation_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/tabs/tab.cc
diff --git a/chrome/browser/views/tabs/tab.cc b/chrome/browser/views/tabs/tab.cc
index 17e5a14d4754e2814a509e0093d7323ae1c82dbc..b519ab280a77491a68094cccdbde2db6f4582429 100644
--- a/chrome/browser/views/tabs/tab.cc
+++ b/chrome/browser/views/tabs/tab.cc
@@ -58,9 +58,13 @@ Tab::TabImage Tab::tab_active = {0};
Tab::TabImage Tab::tab_inactive = {0};
// Durations for the various parts of the mini tab title animation.
-static const int kMiniTitleChangeAnimationDuration1MS = 1000;
-static const int kMiniTitleChangeAnimationDuration2MS = 500;
-static const int kMiniTitleChangeAnimationDuration3MS = 800;
+static const int kMiniTitleChangeAnimationDuration1MS = 1600;
+static const int kMiniTitleChangeAnimationStart1MS = 0;
+static const int kMiniTitleChangeAnimationEnd1MS = 1900;
+static const int kMiniTitleChangeAnimationDuration2MS = 0;
+static const int kMiniTitleChangeAnimationDuration3MS = 550;
+static const int kMiniTitleChangeAnimationStart3MS = 150;
+static const int kMiniTitleChangeAnimationEnd3MS = 800;
// Offset from the right edge for the start of the mini title change animation.
static const int kMiniTitleChangeInitialXOffset = 6;
@@ -117,6 +121,10 @@ void Tab::StartMiniTabTitleAnimation() {
Tween::ZERO));
parts.push_back(MultiAnimation::Part(kMiniTitleChangeAnimationDuration3MS,
Tween::EASE_IN));
+ parts[0].start_time_ms = kMiniTitleChangeAnimationStart1MS;
+ parts[0].end_time_ms = kMiniTitleChangeAnimationEnd1MS;
+ parts[2].start_time_ms = kMiniTitleChangeAnimationStart3MS;
+ parts[2].end_time_ms = kMiniTitleChangeAnimationEnd3MS;
mini_title_animation_.reset(new MultiAnimation(parts));
mini_title_animation_->SetContainer(animation_container());
mini_title_animation_->set_delegate(this);
« no previous file with comments | « app/multi_animation_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698