Issue 304009: Coverity: Fix call to string->empty() that meant ->clear()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304009: Coverity: Fix call to string->empty() that meant ->clear() (Closed)

Created:
11 years, 2 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Coverity: Fix call to string->empty() that meant ->clear() CID=127 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30243

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/spellcheck_worditerator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

Well, at least that's what I assume it meant, since calling empty() without checking the ...

11 years, 2 months ago (2009-10-19 23:31:14 UTC) #1

Hironori Bono

11 years, 1 month ago (2009-10-27 07:46:46 UTC) #2

LGTM.
Sorry for my slow response.
On 2009/10/19 23:31:14, mattm wrote:
> Well, at least that's what I assume it meant, since calling empty() without
> checking the result doesn't seem useful.

Expand Messages | Collapse Messages