Issue 3040052: Make libjingle resolve DNS synchronously to avoid crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3040052: Make libjingle resolve DNS synchronously to avoid crashes. (Closed)

Created:
10 years, 4 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews

Visibility:
Public.

Description

Make libjingle resolve DNS synchronously to avoid crashes. This is another speculative fix for the crash in the big below. BUG=chromeos:5145 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55462

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	jingle/notifier/communicator/login.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

akalin

10 years, 4 months ago (2010-08-09 20:41:51 UTC) #3

trybots are failing because 'git try' probably doesn't work correctly on a
branch.

submitting, since this compiled fine on my machine (and no tests exercise this
anyway)

On 2010/08/09 20:27:36, timsteele wrote:
> lgtm

Expand Messages | Collapse Messages