Issue 3040034: Block non-sandboxed plugins.

Issue 3040034: Block non-sandboxed plugins. (Closed)

Created:
10 years, 4 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org, Pam (message me for reviews)

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Block non-sandboxed plugins. Run Chrome with --block-nonsandboxed-plugins to enable. BUG=47730 TEST=See bug description for manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55041

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix indentation; sync #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -59 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/blocked_plugin_manager.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/browser/blocked_plugin_manager.cc	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1	3 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/renderer/blocked_plugin.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1	2 chunks	+14 lines, -5 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	4 chunks	+63 lines, -50 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

Please review. This is the first half of http://codereview.chromium.org/2967007 (minus some stuff that already landed), ...

10 years, 4 months ago (2010-08-04 15:02:01 UTC) #1

stuartmorgan

10 years, 4 months ago (2010-08-04 17:06:34 UTC) #2

LGTM with nits.

http://codereview.chromium.org/3040034/diff/1/3
File chrome/browser/blocked_plugin_manager.cc (right):

http://codereview.chromium.org/3040034/diff/1/3#newcode29
chrome/browser/blocked_plugin_manager.cc:29: return BUTTON_OK;
Fix indentation.

http://codereview.chromium.org/3040034/diff/1/17
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/3040034/diff/1/17#newcode2248
chrome/renderer/render_view.cc:2248: switches::kBlockNonSandboxedPlugins)) {
This indentation still bothers me, but if you really disagree strongly that
indenting it more helps readability I'll let it go.

Expand Messages | Collapse Messages