Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: net/socket/socket_test_util.h

Issue 3040016: Net: Convert username and password to string16. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address comments Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_transaction_unittest.h ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.h
===================================================================
--- net/socket/socket_test_util.h (revision 53997)
+++ net/socket/socket_test_util.h (working copy)
@@ -16,6 +16,7 @@
#include "base/logging.h"
#include "base/scoped_ptr.h"
#include "base/scoped_vector.h"
+#include "base/string16.h"
#include "net/base/address_list.h"
#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
@@ -636,8 +637,8 @@
const scoped_refptr<ClientSocketPoolHistograms>& histograms,
ClientSocketFactory* socket_factory);
- int release_count() const { return release_count_; };
- int cancel_count() const { return cancel_count_; };
+ int release_count() const { return release_count_; }
+ int cancel_count() const { return cancel_count_; }
// TCPClientSocketPool methods.
virtual int RequestSocket(const std::string& group_name,
@@ -695,7 +696,8 @@
};
struct MockHttpAuthControllerData {
- MockHttpAuthControllerData(std::string header) : auth_header(header) {}
+ explicit MockHttpAuthControllerData(std::string header)
+ : auth_header(header) {}
std::string auth_header;
};
@@ -716,8 +718,8 @@
bool do_not_send_server_auth,
bool establishing_tunnel,
const BoundNetLog& net_log);
- virtual void ResetAuth(const std::wstring& username,
- const std::wstring& password);
+ virtual void ResetAuth(const string16& username,
+ const string16& password);
virtual bool HaveAuthHandler() const;
virtual bool HaveAuth() const;
« no previous file with comments | « net/http/http_transaction_unittest.h ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698