Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: net/http/http_auth_handler_digest_unittest.cc

Issue 3040016: Net: Convert username and password to string16. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address comments Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_digest.cc ('k') | net/http/http_auth_handler_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_digest_unittest.cc
===================================================================
--- net/http/http_auth_handler_digest_unittest.cc (revision 53997)
+++ net/http/http_auth_handler_digest_unittest.cc (working copy)
@@ -2,11 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "testing/gtest/include/gtest/gtest.h"
+#include <string>
#include "base/basictypes.h"
+#include "base/string_util.h"
#include "net/base/net_errors.h"
#include "net/http/http_auth_handler_digest.h"
+#include "testing/gtest/include/gtest/gtest.h"
namespace net {
@@ -276,12 +278,13 @@
HttpAuthHandlerDigest* digest =
static_cast<HttpAuthHandlerDigest*>(handler.get());
- std::string creds = digest->AssembleCredentials(tests[i].req_method,
- tests[i].req_path,
- tests[i].username,
- tests[i].password,
- tests[i].cnonce,
- tests[i].nonce_count);
+ std::string creds =
+ digest->AssembleCredentials(tests[i].req_method,
+ tests[i].req_path,
+ ASCIIToUTF16(tests[i].username),
+ ASCIIToUTF16(tests[i].password),
+ tests[i].cnonce,
+ tests[i].nonce_count);
EXPECT_STREQ(tests[i].expected_creds, creds.c_str());
}
« no previous file with comments | « net/http/http_auth_handler_digest.cc ('k') | net/http/http_auth_handler_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698