Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: net/http/http_auth_handler_digest.h

Issue 3040016: Net: Convert username and password to string16. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address comments Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_basic_unittest.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_digest.h
===================================================================
--- net/http/http_auth_handler_digest.h (revision 53997)
+++ net/http/http_auth_handler_digest.h (working copy)
@@ -6,6 +6,9 @@
#define NET_HTTP_HTTP_AUTH_HANDLER_DIGEST_H_
#pragma once
+#include <string>
+
+#include "base/string16.h"
#include "net/http/http_auth_handler.h"
#include "net/http/http_auth_handler_factory.h"
@@ -36,8 +39,8 @@
return ParseChallenge(challenge);
}
- virtual int GenerateAuthTokenImpl(const std::wstring* username,
- const std::wstring* password,
+ virtual int GenerateAuthTokenImpl(const string16* username,
+ const string16* password,
const HttpRequestInfo* request,
CompletionCallback* callback,
std::string* auth_token);
@@ -97,16 +100,16 @@
// Build up the 'response' production.
std::string AssembleResponseDigest(const std::string& method,
const std::string& path,
- const std::string& username,
- const std::string& password,
+ const string16& username,
+ const string16& password,
const std::string& cnonce,
const std::string& nc) const;
// Build up the value for (Authorization/Proxy-Authorization).
std::string AssembleCredentials(const std::string& method,
const std::string& path,
- const std::string& username,
- const std::string& password,
+ const string16& username,
+ const string16& password,
const std::string& cnonce,
int nonce_count) const;
@@ -121,7 +124,7 @@
std::string opaque_;
bool stale_;
DigestAlgorithm algorithm_;
- int qop_; // Bitfield of QualityOfProtection
+ int qop_; // Bitfield of QualityOfProtection
int nonce_count_;
« no previous file with comments | « net/http/http_auth_handler_basic_unittest.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698