Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: net/http/http_auth.h

Issue 3040016: Net: Convert username and password to string16. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address comments Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_transaction.h ('k') | net/http/http_auth_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth.h
===================================================================
--- net/http/http_auth.h (revision 53997)
+++ net/http/http_auth.h (working copy)
@@ -7,8 +7,10 @@
#pragma once
#include <set>
+#include <string>
#include "base/scoped_ptr.h"
+#include "base/string16.h"
#include "net/http/http_util.h"
template <class T> class scoped_refptr;
@@ -68,9 +70,8 @@
IdentitySource source;
bool invalid;
- // TODO(wtc): |username| and |password| should be string16.
- std::wstring username;
- std::wstring password;
+ string16 username;
+ string16 password;
};
// Get the name of the header containing the auth challenge
« no previous file with comments | « net/ftp/ftp_transaction.h ('k') | net/http/http_auth_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698