Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: net/ftp/ftp_network_transaction.h

Issue 3040016: Net: Convert username and password to string16. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address comments Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_auth_cache_unittest.cc ('k') | net/ftp/ftp_network_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_network_transaction.h
===================================================================
--- net/ftp/ftp_network_transaction.h (revision 53997)
+++ net/ftp/ftp_network_transaction.h (working copy)
@@ -6,13 +6,14 @@
#define NET_FTP_FTP_NETWORK_TRANSACTION_H_
#pragma once
-#include <string>
#include <queue>
+#include <string>
#include <utility>
#include <vector>
#include "base/ref_counted.h"
#include "base/scoped_ptr.h"
+#include "base/string16.h"
#include "net/base/address_list.h"
#include "net/base/host_resolver.h"
#include "net/base/net_log.h"
@@ -37,8 +38,8 @@
CompletionCallback* callback,
const BoundNetLog& net_log);
virtual int Stop(int error);
- virtual int RestartWithAuth(const std::wstring& username,
- const std::wstring& password,
+ virtual int RestartWithAuth(const string16& username,
+ const string16& password,
CompletionCallback* callback);
virtual int RestartIgnoringLastError(CompletionCallback* callback);
virtual int Read(IOBuffer* buf, int buf_len, CompletionCallback* callback);
@@ -201,10 +202,8 @@
// EPSV fail, we fall back to PASV for the duration of connection.
bool use_epsv_;
- // We get username and password as wstrings in RestartWithAuth, so they are
- // also kept as wstrings here.
- std::wstring username_;
- std::wstring password_;
+ string16 username_;
+ string16 password_;
// Current directory on the remote server, as returned by last PWD command,
// with any trailing slash removed.
« no previous file with comments | « net/ftp/ftp_auth_cache_unittest.cc ('k') | net/ftp/ftp_network_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698