Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: net/url_request/url_request_job.cc

Issue 3040016: Net: Convert username and password to string16. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address comments Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_job.h ('k') | net/url_request/url_request_unittest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_job.h" 5 #include "net/url_request/url_request_job.h"
6 6
7 #include "base/histogram.h" 7 #include "base/histogram.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "net/base/auth.h" 10 #include "net/base/auth.h"
11 #include "net/base/io_buffer.h" 11 #include "net/base/io_buffer.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 return false; 103 return false;
104 } 104 }
105 105
106 void URLRequestJob::GetAuthChallengeInfo( 106 void URLRequestJob::GetAuthChallengeInfo(
107 scoped_refptr<net::AuthChallengeInfo>* auth_info) { 107 scoped_refptr<net::AuthChallengeInfo>* auth_info) {
108 // This will only be called if NeedsAuth() returns true, in which 108 // This will only be called if NeedsAuth() returns true, in which
109 // case the derived class should implement this! 109 // case the derived class should implement this!
110 NOTREACHED(); 110 NOTREACHED();
111 } 111 }
112 112
113 void URLRequestJob::SetAuth(const std::wstring& username, 113 void URLRequestJob::SetAuth(const string16& username,
114 const std::wstring& password) { 114 const string16& password) {
115 // This will only be called if NeedsAuth() returns true, in which 115 // This will only be called if NeedsAuth() returns true, in which
116 // case the derived class should implement this! 116 // case the derived class should implement this!
117 NOTREACHED(); 117 NOTREACHED();
118 } 118 }
119 119
120 void URLRequestJob::CancelAuth() { 120 void URLRequestJob::CancelAuth() {
121 // This will only be called if NeedsAuth() returns true, in which 121 // This will only be called if NeedsAuth() returns true, in which
122 // case the derived class should implement this! 122 // case the derived class should implement this!
123 NOTREACHED(); 123 NOTREACHED();
124 } 124 }
(...skipping 769 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 return; 894 return;
895 } 895 }
896 896
897 if (is_compressed_) { 897 if (is_compressed_) {
898 COMPRESSION_HISTOGRAM("NoProxy.BytesBeforeCompression", compressed_B); 898 COMPRESSION_HISTOGRAM("NoProxy.BytesBeforeCompression", compressed_B);
899 COMPRESSION_HISTOGRAM("NoProxy.BytesAfterCompression", decompressed_B); 899 COMPRESSION_HISTOGRAM("NoProxy.BytesAfterCompression", decompressed_B);
900 } else { 900 } else {
901 COMPRESSION_HISTOGRAM("NoProxy.ShouldHaveBeenCompressed", decompressed_B); 901 COMPRESSION_HISTOGRAM("NoProxy.ShouldHaveBeenCompressed", decompressed_B);
902 } 902 }
903 } 903 }
OLDNEW
« no previous file with comments | « net/url_request/url_request_job.h ('k') | net/url_request/url_request_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698