Issue 3040010: Stop pushing arguments onto the stack in CompareStub until just before callin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3040010: Stop pushing arguments onto the stack in CompareStub until just before callin... (Closed)

Created:
10 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Stop pushing arguments onto the stack in CompareStub until just before calling runtime. This is a fixed version of change 5097, which had the problem that LoadFloatOperands tried to load the arguments from the stack. Committed: http://code.google.com/p/v8/source/detail?r=5103

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -39 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		7 chunks	+18 lines, -23 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View		8 chunks	+12 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages