Issue 3040006: Only auto-close dialogs when last browser closes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3040006: Only auto-close dialogs when last browser closes. (Closed)

Created:
10 years, 5 months ago by Andrew T Wilson (Slow)

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

Only auto-close dialogs when last browser closes. Update GTK version of BrowserList::AllBrowsersClosed() to only close widgets that pass the GTK_IS_DIALOG() filter to avoid prematurely closing status icons. BUG=49391 TEST=none (unit test is part of a pending CL) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52945

Patch Set 1 #

Patch Set 2 : Remove code accidentally brought over from other CL #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/browser_list_gtk.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

This is that change to AllBrowsersClosed() we discussed earlier today. Seems to work fine with ...

10 years, 5 months ago (2010-07-17 06:47:01 UTC) #1

tony

10 years, 5 months ago (2010-07-19 16:15:04 UTC) #2

On 2010/07/17 06:47:01, Andrew T Wilson wrote:
> This is that change to AllBrowsersClosed() we discussed earlier today. Seems
to
> work fine with my manual testing (there's a unit test in an upcoming CL that
> passes now also).

LGTM.  Looks like the try bot failed because you ran out of memory when linking
:(

Expand Messages | Collapse Messages