cros-workon: change forall into iterate

cros_workon

 #!/bin/bash
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script moves ebuilds between 'stable' and 'live' states.
 # By default 'stable' ebuilds point at and build from source at the
 # last known good commit. Moving an ebuild to 'live' (via cros_workon start)
 # is intended to support development. The current source tip is fetched,
 # source modified and built using the unstable 'live' (9999) ebuild.
 
 # Load common constants.  This should be the first executable line.
 # The path to common.sh should be relative to your script's location.
 . "$(dirname "$0")/common.sh"
 
 # Script must be run inside the chroot
 restart_in_chroot_if_needed $*
 get_default_board
 
 DEFINE_string board "${DEFAULT_BOARD}" \
   "The board to set package keywords for."
 DEFINE_boolean host "${FLAGS_FALSE}" \
   "Uses the host instead of board"
 DEFINE_string command "git status" \
   "The command to be run by forall."
 DEFINE_boolean all "${FLAGS_FALSE}" \
   "Apply to all possible packages for the given command"
 
-FLAGS_HELP="usage: $0 <command> [flags]
+FLAGS_HELP="usage: $0 <command> [flags] [<list of packages>|--all]
 commands:
   start:  Moves an ebuild to live (intended to support development)
   stop:  Moves an ebuild to stable (use last known good)
   list:  List of live ebuilds (workon ebuilds if --all)
-  forall:  For each ebuild, cd to the source dir and run a commond"
+  iterate:  For each ebuild, cd to the source dir and run a commond"
 FLAGS "$@" || exit 1
 eval set -- "${FLAGS_ARGV}"
 
 
 # eat the workon command keywords: start, stop or list.
 WORKON_CMD=$1
 shift
 
 
 # board dir config
@@ skipping 91 matching lines @@
       sudo bash -c "grep -v '^~${atom}-9999\$' \"${UNMASK_FILE}\" > \
           \"${UNMASK_FILE}+\""
       sudo mv "${UNMASK_FILE}+" "${UNMASK_FILE}"
     else
       warn "Not working on ${atom}"
     fi
   done
 }
 
 # Run a command on all or a set of repos.
-ebuild_forall() {
+ebuild_iterate() {
   local atoms=$1
 
   for atom in ${atoms}; do
     info "Running \"${FLAGS_command}\" on ${atom}"
     eval $(${EBUILDCMD} $(${EQUERYCMD} which ${atom}) info)
     (cd "${CROS_WORKON_SRCDIR}" && bash -c "${FLAGS_command}")
   done
 }
 
 show_workon_ebuilds() {
   pushd "${BOARD_DIR}"/etc/ 1> /dev/null
   source make.conf
   popd 1> /dev/null
   local CROS_OVERLAYS="${PORTDIR_OVERLAY}"
 
   for overlay in ${CROS_OVERLAYS}; do
     pushd ${overlay} 1> /dev/null
     find . -name '*.ebuild' | xargs fgrep cros-workon | \
       awk -F / '{ print $2 "/" $3 }' | uniq | sort
     popd 1> /dev/null
   done
 }
 
 # --all makes commands operate on different lists
 if [ ${FLAGS_all} = "${FLAGS_TRUE}" ]; then
   case ${WORKON_CMD} in
     start) ATOM_LIST=$(show_workon_ebuilds);;
-    stop) ATOM_LIST=$(show_live_ebuilds);;
+    stop|iterate) ATOM_LIST=$(show_live_ebuilds);;
     list) ;;
     *) die "--all is invalid for the given command";;
   esac
 else # not selected --all
   ATOM_LIST=$@
-  case ${WORKON_CMD} in
-    start|stop)
-      if [ -z "${ATOM_LIST}" ]; then
-        die "${WORKON_CMD}: No packages specified"
-      elif ! ATOM_LIST=$(canonicalize_names "${ATOM_LIST}"); then
-        die "Error parsing package list"
-      fi;;
-    forall)
-      if [ -z "${ATOM_LIST}" ]; then
-        ATOM_LIST=$(show_workon_ebuilds)
-      elif ! ATOM_LIST=$(canonicalize_names "${ATOM_LIST}"); then
-        die "Error parsing package list"
-      fi;;
-    *) ;;
-  esac
+  if [ -z "${ATOM_LIST}" ]; then
+    die "${WORKON_CMD}: No packages specified"
+  elif ! ATOM_LIST=$(canonicalize_names "${ATOM_LIST}"); then
+    die "Error parsing package list"
+  fi
 fi
 
 case ${WORKON_CMD} in
   start)  ebuild_to_live "${ATOM_LIST}" ;;
   stop)   ebuild_to_stable "${ATOM_LIST}" ;;
   list)   [ ${FLAGS_all} = "${FLAGS_FALSE}" ] && show_live_ebuilds || show_workon_ebuilds ;;
-  forall) ebuild_forall "${ATOM_LIST}" ;;
+  iterate) ebuild_iterate "${ATOM_LIST}" ;;
   *)      die "invalid cros_workon command" ;;
 esac