AutoFill Assert with AutoFillManager unique ids and Credit Card filling

AutoFill Assert with AutoFillManager unique ids and Credit Card filling

Changes unique id matching that happens between browser and renderer.  Unique ids sent between processes are now combined in the case where credit card and address combination suggestions are supplied to popup.

BUG=50264
TEST=AutoFillManagerTest.FillCreditCardForm, AutoFillManagerTest.FillNonBillingFormSemicolon, AutoFillManagerTest.FillBillFormSemicolon

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53879

[James Hawkins, 2010-07-27 18:49:53]

http://codereview.chromium.org/3039031/diff/1/2
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3039031/diff/1/2#newcode83
chrome/browser/autofill/autofill_manager.cc:83: DCHECK(cc_id <= 0xFFFF);
How about using limits?

http://codereview.chromium.org/3039031/diff/1/2#newcode89
chrome/browser/autofill/autofill_manager.cc:89: // When receiving ids (across
processes) from the renderer we unpack credit card
s/ids/IDs/ here and elsewhere.

http://codereview.chromium.org/3039031/diff/1/4
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/3039031/diff/1/4#newcode734
chrome/browser/autofill/autofill_manager_unittest.cc:734: 4 << 16 | 1));
We should use the function here to create the ID.

[dhollowa, 2010-07-27 21:16:47]

http://codereview.chromium.org/3039031/diff/1/2
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3039031/diff/1/2#newcode83
chrome/browser/autofill/autofill_manager.cc:83: DCHECK(cc_id <= 0xFFFF);
On 2010/07/27 18:49:53, James Hawkins wrote:
> How about using limits?

Done.

http://codereview.chromium.org/3039031/diff/1/2#newcode89
chrome/browser/autofill/autofill_manager.cc:89: // When receiving ids (across
processes) from the renderer we unpack credit card
On 2010/07/27 18:49:53, James Hawkins wrote:
> s/ids/IDs/ here and elsewhere.

Done.

http://codereview.chromium.org/3039031/diff/1/4
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/3039031/diff/1/4#newcode734
chrome/browser/autofill/autofill_manager_unittest.cc:734: 4 << 16 | 1));
On 2010/07/27 18:49:53, James Hawkins wrote:
> We should use the function here to create the ID.

Done.

[James Hawkins, 2010-07-27 21:23:11]

http://codereview.chromium.org/3039031/diff/6001/7001
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3039031/diff/6001/7001#newcode85
chrome/browser/autofill/autofill_manager.cc:85: // Note: Using external linkage
for use in unit tests.
I'd rather make it a private static method on the class and make the test a
friend of the class (or public if that's too much trouble).

[dhollowa, 2010-07-27 23:15:39]

http://codereview.chromium.org/3039031/diff/6001/7001
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3039031/diff/6001/7001#newcode85
chrome/browser/autofill/autofill_manager.cc:85: // Note: Using external linkage
for use in unit tests.
On 2010/07/27 21:23:11, James Hawkins wrote:
> I'd rather make it a private static method on the class and make the test a
> friend of the class (or public if that's too much trouble).

Done.  Kept public though due to non-cooperation of FRIEND_TEST with statics.

[James Hawkins, 2010-07-27 23:20:46]

LGTM with nits.

http://codereview.chromium.org/3039031/diff/13001/14001
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3039031/diff/13001/14001#newcode736
chrome/browser/autofill/autofill_manager.cc:736: int
AutoFillManager::PackIDs(int cc_id, int profile_id) {
It looks like these should be positioned after UploadFormData.

http://codereview.chromium.org/3039031/diff/13001/14002
File chrome/browser/autofill/autofill_manager.h (right):

http://codereview.chromium.org/3039031/diff/13001/14002#newcode89
chrome/browser/autofill/autofill_manager.h:89: // Methods for packing and
unpacking credit card and profile ids for sending
IDs

[dhollowa, 2010-07-27 23:30:28]

http://codereview.chromium.org/3039031/diff/13001/14001
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3039031/diff/13001/14001#newcode736
chrome/browser/autofill/autofill_manager.cc:736: int
AutoFillManager::PackIDs(int cc_id, int profile_id) {
On 2010/07/27 23:20:46, James Hawkins wrote:
> It looks like these should be positioned after UploadFormData.

Done.

http://codereview.chromium.org/3039031/diff/13001/14002
File chrome/browser/autofill/autofill_manager.h (right):

http://codereview.chromium.org/3039031/diff/13001/14002#newcode89
chrome/browser/autofill/autofill_manager.h:89: // Methods for packing and
unpacking credit card and profile ids for sending
On 2010/07/27 23:20:46, James Hawkins wrote:
> IDs

Done.

[James Hawkins, 2010-07-28 00:14:58]

SLGTM