Issue 3039025: Fix aliasing problem in inlined stores on x64 and ia32. The receiver...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3039025: Fix aliasing problem in inlined stores on x64 and ia32. The receiver... (Closed)

Created:
10 years, 5 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix aliasing problem in inlined stores on x64 and ia32. The receiver and the value can share a register. We need to remove this aliasing before modifying the registers. I haven't managed to generate a stand-alon test case for this yet. I'll do that as a separate change. This was found while loading Wave. Committed: http://code.google.com/p/v8/source/detail?r=5127

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -8 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		1 chunk	+9 lines, -4 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View		1 chunk	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages