Issue 3039016: Part 2 of Make NaCl/Chromium startup interface easier to maintain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3039016: Part 2 of Make NaCl/Chromium startup interface easier to maintain (Closed)

Created:
10 years, 5 months ago by Mark Seaborn

Modified:
9 years, 5 months ago

Reviewers:
sehr (please use chromium), gregoryd

CC:
chromium-reviews, native-client-reviews_googlegroups.com, Mark Schneckloth, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Make NaCl/Chromium startup interface easier to maintain Use the new NaClMainForChromium() from the NaCl tree, instead of sel_main.cc in the Chromium tree. Use the new variant of RegisterInternalNaClPlugin() that can receive multiple functions instead of just one. This depends on r2744 from NaCl. BUG=http://code.google.com/p/nativeclient/issues/detail?id=642 BUG=http://code.google.com/p/nativeclient/issues/detail?id=469 TEST=Chromium's nacl_ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53952

Patch Set 1 #

Patch Set 2 : Use new RegisterInternalNaClPlugin() #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -204 lines)			Patch
M	chrome/nacl.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/nacl/nacl_thread.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
D	chrome/nacl/sel_main.cc	View	1 chunk	+0 lines, -199 lines	0 comments	Download
M	chrome/renderer/render_process_impl.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

This is a two-sided commit. It depends on: http://codereview.chromium.org/2806061/show

10 years, 5 months ago (2010-07-20 13:48:13 UTC) #1

gregoryd

The new version of RegisterInternalNaClPlugin is not used in this CL

10 years, 5 months ago (2010-07-20 20:19:16 UTC) #2

Mark Seaborn

On 2010/07/20 20:19:16, gregoryd wrote: > The new version of RegisterInternalNaClPlugin is not used in ...

10 years, 5 months ago (2010-07-20 20:58:08 UTC) #3

LGTM

Expand Messages | Collapse Messages