AutoFill Profiles dialog handles multi-select and delete on Mac

chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/ref_counted.h"
 #import "chrome/browser/autofill/autofill_address_model_mac.h"
 #import "chrome/browser/autofill/autofill_address_sheet_controller_mac.h"
 #import "chrome/browser/autofill/autofill_credit_card_model_mac.h"
 #import "chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.h"
 #import "chrome/browser/autofill/autofill_dialog_controller_mac.h"
@@ skipping 371 matching lines @@
   LoadDialog();
   [controller_ addNewAddress:nil];
   AutoFillAddressSheetController* sheet = [controller_ addressSheetController];
   ASSERT_TRUE(sheet != nil);
   [sheet save:nil];
   [controller_ save:nil];
 
   // Should hit our observer.
   ASSERT_TRUE(observer_.hit_);
 
-  // Sizes should match be different.  New size should be 2.
+  // Sizes should be different.  New size should be 2.
   ASSERT_NE(observer_.profiles_.size(), profiles().size());
   ASSERT_EQ(observer_.profiles_.size(), 2UL);
 
   // New address should match.
   AutoFillProfile new_profile;
   ASSERT_EQ(observer_.profiles_[1], new_profile);
 }
 
 TEST_F(AutoFillDialogControllerTest, AddNewCreditCard) {
   CreditCard credit_card(ASCIIToUTF16("Visa"), 1);
   credit_card.SetInfo(AutoFillType(CREDIT_CARD_NAME), ASCIIToUTF16("Joe"));
   credit_cards().push_back(&credit_card);
   LoadDialog();
   [controller_ addNewCreditCard:nil];
   AutoFillCreditCardSheetController* sheet =
       [controller_ creditCardSheetController];
   ASSERT_TRUE(sheet != nil);
   [sheet save:nil];
   [controller_ save:nil];
 
   // Should hit our observer.
   ASSERT_TRUE(observer_.hit_);
 
-  // Sizes should match be different.  New size should be 2.
+  // Sizes should be different.  New size should be 2.
   ASSERT_NE(observer_.credit_cards_.size(), credit_cards().size());
   ASSERT_EQ(observer_.credit_cards_.size(), 2UL);
 
   // New address should match.
   CreditCard new_credit_card;
   ASSERT_EQ(observer_.credit_cards_[1], new_credit_card);
 }
 
 TEST_F(AutoFillDialogControllerTest, DeleteProfile) {
   AutoFillProfile profile(ASCIIToUTF16("One"), 1);
   profile.SetInfo(AutoFillType(NAME_FIRST), ASCIIToUTF16("Joe"));
   profiles().push_back(&profile);
   LoadDialog();
   [controller_ selectAddressAtIndex:0];
   [controller_ deleteSelection:nil];
   [controller_ save:nil];
 
   // Should hit our observer.
   ASSERT_TRUE(observer_.hit_);
 
-  // Sizes should match be different.  New size should be 0.
+  // Sizes should be different.  New size should be 0.
   ASSERT_NE(observer_.profiles_.size(), profiles().size());
   ASSERT_EQ(observer_.profiles_.size(), 0UL);
 }
 
 TEST_F(AutoFillDialogControllerTest, DeleteCreditCard) {
   CreditCard credit_card(ASCIIToUTF16("Visa"), 1);
   credit_card.SetInfo(AutoFillType(CREDIT_CARD_NAME), ASCIIToUTF16("Joe"));
   credit_cards().push_back(&credit_card);
   LoadDialog();
   [controller_ selectCreditCardAtIndex:0];
   [controller_ deleteSelection:nil];
   [controller_ save:nil];
 
   // Should hit our observer.
   ASSERT_TRUE(observer_.hit_);
 
-  // Sizes should match be different.  New size should be 0.
+  // Sizes should be different.  New size should be 0.
   ASSERT_NE(observer_.credit_cards_.size(), credit_cards().size());
   ASSERT_EQ(observer_.credit_cards_.size(), 0UL);
 }
 
 TEST_F(AutoFillDialogControllerTest, TwoProfilesDeleteOne) {
   AutoFillProfile profile(ASCIIToUTF16("One"), 1);
   profile.SetInfo(AutoFillType(NAME_FIRST), ASCIIToUTF16("Joe"));
   profiles().push_back(&profile);
   AutoFillProfile profile2(ASCIIToUTF16("Two"), 2);
   profile2.SetInfo(AutoFillType(NAME_FIRST), ASCIIToUTF16("Bob"));
   profiles().push_back(&profile2);
   LoadDialog();
   [controller_ selectAddressAtIndex:1];
   [controller_ deleteSelection:nil];
   [controller_ save:nil];
 
   // Should hit our observer.
   ASSERT_TRUE(observer_.hit_);
 
-  // Sizes should match be different.  New size should be 0.
+  // Sizes should be different.  New size should be 1.
   ASSERT_NE(observer_.profiles_.size(), profiles().size());
   ASSERT_EQ(observer_.profiles_.size(), 1UL);
 
   // First address should match.
   profiles()[0]->set_unique_id(observer_.profiles_[0].unique_id());
 
   // Do not compare labels.  Label is a derived field.
   observer_.profiles_[0].set_label(string16());
   profile.set_label(string16());
   ASSERT_EQ(observer_.profiles_[0], profile);
 }
 
 TEST_F(AutoFillDialogControllerTest, TwoCreditCardsDeleteOne) {
   CreditCard credit_card(ASCIIToUTF16("Visa"), 1);
   credit_card.SetInfo(AutoFillType(CREDIT_CARD_NAME), ASCIIToUTF16("Joe"));
   credit_cards().push_back(&credit_card);
   CreditCard credit_card2(ASCIIToUTF16("Mastercard"), 2);
   credit_card2.SetInfo(AutoFillType(CREDIT_CARD_NAME), ASCIIToUTF16("Bob"));
   credit_cards().push_back(&credit_card2);
   LoadDialog();
   [controller_ selectCreditCardAtIndex:1];
   [controller_ deleteSelection:nil];
   [controller_ save:nil];
 
   // Should hit our observer.
   ASSERT_TRUE(observer_.hit_);
 
-  // Sizes should match be different.  New size should be 0.
+  // Sizes should be different.  New size should be 1.
   ASSERT_NE(observer_.credit_cards_.size(), credit_cards().size());
   ASSERT_EQ(observer_.credit_cards_.size(), 1UL);
 
   // First credit card should match.
   credit_cards()[0]->set_unique_id(observer_.credit_cards_[0].unique_id());
   ASSERT_EQ(observer_.credit_cards_[0], credit_card);
 }
 
+TEST_F(AutoFillDialogControllerTest, DeleteMultiple) {
+  AutoFillProfile profile(ASCIIToUTF16("One"), 1);
+  profile.SetInfo(AutoFillType(NAME_FIRST), ASCIIToUTF16("Joe"));
+  profiles().push_back(&profile);
+  AutoFillProfile profile2(ASCIIToUTF16("Two"), 2);
+  profile2.SetInfo(AutoFillType(NAME_FIRST), ASCIIToUTF16("Bob"));
+  profiles().push_back(&profile2);
+
+  CreditCard credit_card(ASCIIToUTF16("Visa"), 1);
+  credit_card.SetInfo(AutoFillType(CREDIT_CARD_NAME), ASCIIToUTF16("Joe"));
+  credit_cards().push_back(&credit_card);
+  CreditCard credit_card2(ASCIIToUTF16("Mastercard"), 2);
+  credit_card2.SetInfo(AutoFillType(CREDIT_CARD_NAME), ASCIIToUTF16("Bob"));
+  credit_cards().push_back(&credit_card2);
+
+  LoadDialog();
+  [controller_ selectAddressAtIndex:1];
+  [controller_ addSelectedCreditCardAtIndex:0];
+  ASSERT_FALSE([controller_ editButtonEnabled]);
+  [controller_ deleteSelection:nil];
+  [controller_ selectAddressAtIndex:0];
+  ASSERT_TRUE([controller_ editButtonEnabled]);
+  [controller_ save:nil];
+
+  // Should hit our observer.
+  ASSERT_TRUE(observer_.hit_);
+
+  // Sizes should be different.  New size should be 1.
+  ASSERT_NE(observer_.profiles_.size(), profiles().size());
+  ASSERT_EQ(observer_.profiles_.size(), 1UL);
+
+  // Sizes should be different.  New size should be 1.
+  ASSERT_NE(observer_.credit_cards_.size(), credit_cards().size());
+  ASSERT_EQ(observer_.credit_cards_.size(), 1UL);
+
+  // First address should match.
+  profiles()[0]->set_unique_id(observer_.profiles_[0].unique_id());
+
+  // Do not compare labels.  Label is a derived field.
+  observer_.profiles_[0].set_label(string16());
+  profile.set_label(string16());
+  ASSERT_EQ(observer_.profiles_[0], profile);
+
+  // Second credit card should match.
+  credit_cards()[0]->set_unique_id(observer_.credit_cards_[0].unique_id());
+  ASSERT_EQ(observer_.credit_cards_[0], credit_card2);
+}
+
 // Auxilliary profiles are enabled by default.
 TEST_F(AutoFillDialogControllerTest, AuxiliaryProfilesTrue) {
   LoadDialog();
   [controller_ save:nil];
 
   // Should hit our observer.
   ASSERT_TRUE(observer_.hit_);
 
   // Auxiliary profiles setting should be unchanged.
   ASSERT_TRUE(helper_.profile()->GetPrefs()->GetBoolean(
@@ skipping 128 matching lines @@
 
   // Should hit our observer.
   ASSERT_TRUE(observer_.hit_);
 
   // Auxiliary profiles setting should be unchanged.
   ASSERT_TRUE(helper_.profile()->GetPrefs()->GetBoolean(
       prefs::kAutoFillEnabled));
 }
 
 }  // namespace