Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 3039002: Allow specifying optional parameters to pass to the Authorization token URL. (Closed)

Created:
10 years, 5 months ago by kurrik.chromium
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, chrome-devrel_googlegroups.com, bkennish
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Allow specifying optional parameters to pass to the Authorization token URL. * For an example of such parameters, see http://code.google.com/apis/accounts/docs/OAuth_ref.html#GetAuth * Updates all samples which use the chrome_ex_oauth.js library to the most recent code. * Bumps the versions of all samples which got an updated OAuth library. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54841

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
kurrik.chromium
I'm updating the OAuth library to support optional Google parameters in the Authorization token URL. ...
10 years, 5 months ago (2010-07-15 22:37:21 UTC) #1
Aaron Boodman
Shame that the library code is copied that way, but I can't think of a ...
10 years, 4 months ago (2010-08-02 21:32:52 UTC) #2
kurrik.chromium
10 years, 4 months ago (2010-08-03 23:36:56 UTC) #3
I was pretty unhappy about this too.  Do you think we could move the library to
another project and do something with svn:externals?  Or would it be possible to
move the library into a central location and use symlinks? I'm not really sure
what the standard practices are in this kind of situation.

On 2010/08/02 21:32:52, Aaron Boodman wrote:
> Shame that the library code is copied that way, but I can't think of a
> workaround.
> 
> LGTM

Powered by Google App Engine
This is Rietveld 408576698