Issue 3038049: Protect against receiving different BINDSTATUS_MIMETYPEAVAILABLE multiple tim...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3038049: Protect against receiving different BINDSTATUS_MIMETYPEAVAILABLE multiple tim... (Closed)

Created:
10 years, 4 months ago by stoyan

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Protect against receiving different BINDSTATUS_MIMETYPEAVAILABLE multiple times. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54979

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	chrome_frame/protocol_sink_wrap.cc	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ananta

10 years, 4 months ago (2010-08-04 22:19:23 UTC) #2

LGTM

http://codereview.chromium.org/3038049/diff/1/2
File chrome_frame/protocol_sink_wrap.cc (right):

http://codereview.chromium.org/3038049/diff/1/2#newcode363
chrome_frame/protocol_sink_wrap.cc:363: // BINDSTATUS_MIMETYPEAVAILABLE is
received receive.
remove receive?

http://codereview.chromium.org/3038049/diff/1/2#newcode372
chrome_frame/protocol_sink_wrap.cc:372: // OTHER  - 2nd (and any subsequent)
BINDSTATUS_MIMETYPEAVAILABLE are
is?

Expand Messages | Collapse Messages