Issue 3038036: Add a PRESUBMIT check for header files that are missing the |#pragma once| directive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3038036: Add a PRESUBMIT check for header files that are missing the |#pragma once| directive. (Closed)

Created:
10 years, 4 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
Nico, M-A Ruel

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add a PRESUBMIT check for header files that are missing the |#pragma once| directive. BUG=none TEST=Have a change with a .h that doens't have a |#pragma once|. Get a warning.

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

10 years, 4 months ago (2010-07-29 15:45:04 UTC) #2

Hrm, I was thinking of reverting this pragma thing, it doesn't seem to help
(incredibuild does file system virutalization and uses stock msvc for
compilation, so it should mostly have the same perf characteristics as local
builds I think.) haven't thought this through yet tho

Expand Messages | Collapse Messages