Issue 3038035: Fix the build - forgot to check in a file....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3038035: Fix the build - forgot to check in a file.... (Closed)

Created:
10 years, 4 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix the build - forgot to check in a file. BUG=none TEST=Bots go green. TBR=erg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54103

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/dom_ui/fileicon_source.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

10 years, 4 months ago (2010-07-29 16:36:10 UTC) #2

LGTM

On Jul 29, 2010 12:02 AM, <thestig@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> doh
>
> Description:
> Fix the build - forgot to check in a file.
>
> BUG=none
> TEST=Bots go green.
> TBR=erg
>
> Please review this at http://codereview.chromium.org/3038035/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> M chrome/browser/dom_ui/fileicon_source.cc
>
>
> Index: chrome/browser/dom_ui/fileicon_source.cc
> ===================================================================
> --- chrome/browser/dom_ui/fileicon_source.cc (revision 54099)
> +++ chrome/browser/dom_ui/fileicon_source.cc (working copy)
> @@ -5,6 +5,7 @@
> #include "chrome/browser/dom_ui/fileicon_source.h"
>
> #include "base/callback.h"
> +#include "base/ref_counted_memory.h"
> #include "base/utf_string_conversions.h"
> #include "chrome/browser/browser_process.h"
> #include "chrome/common/time_format.h"
>
>

Expand Messages | Collapse Messages