add shift key (Shift_L) LED to factory_Leds test

add shift key (Shift_L) LED to factory_Leds test 

BUG=chrome-os-partner:346
TEST=manual

[Tammo Spalink, 2010-08-20 05:22:10]

http://codereview.chromium.org/3038034/diff/1/2
File client/site_tests/factory_Leds/factory_Leds.py (right):

http://codereview.chromium.org/3038034/diff/1/2#newcode11
client/site_tests/factory_Leds/factory_Leds.py:11: 
should actually be two lines here

http://codereview.chromium.org/3038034/diff/1/2#newcode54
client/site_tests/factory_Leds/factory_Leds.py:54: 
should also be 2 lines here

http://codereview.chromium.org/3038034/diff/1/2#newcode165
client/site_tests/factory_Leds/factory_Leds.py:165: elif re.search('shift',
self._current_pattern) and \
re seems like a sledgehammer for this, can we not just call it shift and match
the full string, or use startswith()?

http://codereview.chromium.org/3038034/diff/1/2#newcode197
client/site_tests/factory_Leds/factory_Leds.py:197: image_size =
(image.get_width(), image.get_height())
i do not think you want to be clobbering image_size here

[tbroch1, 2010-08-20 21:11:38]

http://codereview.chromium.org/3038034/diff/1/2
File client/site_tests/factory_Leds/factory_Leds.py (right):

http://codereview.chromium.org/3038034/diff/1/2#newcode11
client/site_tests/factory_Leds/factory_Leds.py:11: 
On 2010/08/20 05:22:10, Tammo Spalink wrote:
> should actually be two lines here

Done.

http://codereview.chromium.org/3038034/diff/1/2#newcode54
client/site_tests/factory_Leds/factory_Leds.py:54: 
On 2010/08/20 05:22:10, Tammo Spalink wrote:
> should also be 2 lines here

Done.

http://codereview.chromium.org/3038034/diff/1/2#newcode165
client/site_tests/factory_Leds/factory_Leds.py:165: elif re.search('shift',
self._current_pattern) and \
On 2010/08/20 05:22:10, Tammo Spalink wrote:
> re seems like a sledgehammer for this, can we not just call it shift and match
> the full string, or use startswith()?
> 

Done.

http://codereview.chromium.org/3038034/diff/1/2#newcode197
client/site_tests/factory_Leds/factory_Leds.py:197: image_size =
(image.get_width(), image.get_height())
On 2010/08/20 05:22:10, Tammo Spalink wrote:
> i do not think you want to be clobbering image_size here

Done.

[Tammo Spalink, 2010-08-23 02:43:28]

lgtm