Issue 3038031: Set the initial focus when the task manager first activates and shows. Also,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3038031: Set the initial focus when the task manager first activates and shows. Also,... (Closed)

Created:
10 years, 4 months ago by David Tseng

Modified:
9 years, 5 months ago

Reviewers:
Chris Guillory, dmazzoni

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Set the initial focus when the task manager first activates and shows. Also, send our custom accessibility events in NativeControl's Focus() method. BUG=50401 TEST=interactive UI tests BrowserKeyboardAccessibility.TabInTaskManager Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53959

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/views/task_manager_view.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	views/controls/native_control.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Chris Guillory

http://codereview.chromium.org/3038031/diff/1/3 File views/controls/native_control.cc (right): http://codereview.chromium.org/3038031/diff/1/3#newcode273 views/controls/native_control.cc:273: NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS); Curious: Why send focus for our view here? ...

10 years, 4 months ago (2010-07-28 16:53:29 UTC) #3

David Tseng

10 years, 4 months ago (2010-07-28 17:22:32 UTC) #4

Good point; I'll change this over in the test tabbing patch that has
support for not firing native notifications.

On 7/28/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
>
> http://codereview.chromium.org/3038031/diff/1/3
> File views/controls/native_control.cc (right):
>
> http://codereview.chromium.org/3038031/diff/1/3#newcode273
> views/controls/native_control.cc:273:
> NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS);
> Curious: Why send focus for our view here? Aren't we using the
> accessibility support provided by the native control?
>
> http://codereview.chromium.org/3038031/show
>

Expand Messages | Collapse Messages