Implement the "Configure modifier keys" drop-down

Implement the "Configure modifier keys" drop-down which enables users to swap Alt/Ctrl keys and Search/Ctrl keys.

BUG=chromium-os:2636
TEST=manually on eeepc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53764

[satorux1, 2010-07-26 08:20:10]

http://codereview.chromium.org/3038025/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/3038025/diff/1/2#newcode8449
chrome/app/generated_resources.grd:8449: Swap Search and Left Control keys
If I understand right, the UI added by this change is temporary and  will be
replaced by the DOM UI version, right? If so, translating these messages seems
to be waste of resources.

[satorux1, 2010-07-26 08:28:05]

http://codereview.chromium.org/3038025/diff/1/6
File chrome/browser/chromeos/options/system_page_view.cc (right):

http://codereview.chromium.org/3038025/diff/1/6#newcode405
chrome/browser/chromeos/options/system_page_view.cc:405:
NotifyPrefChanged(NULL);
Should we call this manually? I thought NotifyPrefChanged() is called by the
parent class...

http://codereview.chromium.org/3038025/diff/1/7
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/3038025/diff/1/7#newcode305
chrome/browser/chromeos/preferences.cc:305: if (!pref_name || *pref_name ==
kXkbModifierMultipleChoicePrefs.pref_name) {
You might want to define enum here;

enum RemapType {
   kNoRemap = 0;
   kSwapCtrlAndAlt = 1;
   kSwapSearchAndCtrl = 2;
}

[Yusuke Sato, 2010-07-26 11:40:00]

http://codereview.chromium.org/3038025/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/3038025/diff/1/2#newcode8449
chrome/app/generated_resources.grd:8449: Swap Search and Left Control keys
As we talked offline, I'd keep them since LanguageMultipleChoicePreference
requires them.

On 2010/07/26 08:20:10, satorux1 wrote:
> If I understand right, the UI added by this change is temporary and  will be
> replaced by the DOM UI version, right? If so, translating these messages seems
> to be waste of resources.

http://codereview.chromium.org/3038025/diff/1/6
File chrome/browser/chromeos/options/system_page_view.cc (right):

http://codereview.chromium.org/3038025/diff/1/6#newcode405
chrome/browser/chromeos/options/system_page_view.cc:405:
NotifyPrefChanged(NULL);
For the combobox, I believe we have to initialize it manually here. Please check
the comment on L404-405.

http://codereview.chromium.org/3038025/diff/1/7
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/3038025/diff/1/7#newcode305
chrome/browser/chromeos/preferences.cc:305: if (!pref_name || *pref_name ==
kXkbModifierMultipleChoicePrefs.pref_name) {
On 2010/07/26 08:28:05, satorux1 wrote:
> You might want to define enum here;
> 
> enum RemapType {
>    kNoRemap = 0;
>    kSwapCtrlAndAlt = 1;
>    kSwapSearchAndCtrl = 2;
> }

Done.

[satorux1, 2010-07-27 00:40:00]

LGTM