Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 3038010: Roll webkit DEPS 63669:63692. (Closed)

Created:
10 years, 5 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews, scherkus (not reviewing), fbarchard, darin-cc_chromium.org, awong, Alpha Left Google
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Roll webkit DEPS 63669:63692. Also fix video tests after webkit r63684. Webkit r63684 removes the load event, so change the layout tests to use canplaythrough instead. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52971

Patch Set 1 #

Patch Set 2 : deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/media/bear.html View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/media/manybear.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
http://trac.webkit.org/changeset/63684
10 years, 5 months ago (2010-07-19 22:14:53 UTC) #1
ojan
10 years, 5 months ago (2010-07-19 22:24:14 UTC) #2
LGTM

On Mon, Jul 19, 2010 at 3:14 PM, <tony@chromium.org> wrote:

> Reviewers: ojan, scherkus,
>
> Message:
> http://trac.webkit.org/changeset/63684
>
> Description:
> Fix video tests after webkit r63684
>
> Webkit r63684 removes the load event, so change the layout
> tests to use canplaythrough instead.
>
> Please review this at http://codereview.chromium.org/3038010/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M webkit/data/media/bear.html
>  M webkit/data/media/manybear.html
>
>
> Index: webkit/data/media/bear.html
> diff --git a/webkit/data/media/bear.html b/webkit/data/media/bear.html
> index
>
1dde7446fdd44b2d31812e986f4fec803c828c32..9cc3682bd1b70ccf6da5a53f09062a513a1314d4
> 100644
> --- a/webkit/data/media/bear.html
> +++ b/webkit/data/media/bear.html
> @@ -5,7 +5,7 @@
>   layoutTestController.waitUntilDone();
>
>   var v = document.getElementById('v');
> -  v.addEventListener('load', function() {
> +  v.addEventListener('canplaythrough', function() {
>     window.setTimeout("layoutTestController.notifyDone();", 1000);
>   }, false);
>   v.src = 'bear_silent.ogv';
> Index: webkit/data/media/manybear.html
> diff --git a/webkit/data/media/manybear.html
> b/webkit/data/media/manybear.html
> index
>
066c27018ef736b26e60ae27feb9ba92e3741c77..2ebf5ffe532b9ea88409622dedd0ac140df4ddb9
> 100644
> --- a/webkit/data/media/manybear.html
> +++ b/webkit/data/media/manybear.html
> @@ -23,7 +23,7 @@
>       v = document.createElement("video");
>       c.appendChild(v);
>       v.src = file;
> -      v.addEventListener("load", function () { loop(); }, false);
> +      v.addEventListener("canplaythrough", function () { loop(); },
> false);
>       v.load();
>     }
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698