Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 3038001: Reapply r51857 to start building chromoting plugin. Update for ppapi changes. (Closed)

Created:
10 years, 5 months ago by awong
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, Sergey Ulanov, dmac, awong, garykac, Alpha Left Google
Visibility:
Public.

Description

Reapply r51857 to start building chromoting plugin. Update for ppapi changes. This should work now after the ppapi roll to r164 that fixes the -fvisibility=hidden being removed in the linux shlib build. Original Review here: http://codereview.chromium.org/2858037 BUG=none TEST=try bots + local run of PPAPITest with a shared_library build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52658

Patch Set 1 #

Patch Set 2 : rebased correctly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -390 lines) Patch
M remoting/client/chromoting_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/client/chromoting_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/client/plugin/chromoting_plugin.h View 4 chunks +22 lines, -16 lines 0 comments Download
M remoting/client/plugin/chromoting_plugin.cc View 6 chunks +34 lines, -48 lines 0 comments Download
M remoting/client/plugin/pepper_entrypoints.cc View 1 chunk +29 lines, -206 lines 0 comments Download
A remoting/client/plugin/pepper_util.h View 1 chunk +32 lines, -0 lines 0 comments Download
A remoting/client/plugin/pepper_util.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M remoting/client/plugin/pepper_view.h View 3 chunks +29 lines, -22 lines 0 comments Download
M remoting/client/plugin/pepper_view.cc View 2 chunks +142 lines, -92 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +4 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698