Issue 3037052: Convert browser/dom_ui/f*.cc to not use wstrings/wchar_t*s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3037052: Convert browser/dom_ui/f.cc to not use wstrings/wchar_ts. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, Evan Martin

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

Convert browser/dom_ui/f*.cc to not use wstrings/wchar_t*s. BUG=23581 TEST=builds and tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55346

Patch Set 2 : changed per thestig #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -59 lines)			Patch
	M	chrome/browser/dom_ui/filebrowse_ui.cc	View	1	7 chunks	+57 lines, -57 lines	0 comments	Download
	M	chrome/browser/dom_ui/font_settings_handler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM http://codereview.chromium.org/3037052/diff/1/2 File chrome/browser/dom_ui/filebrowse_ui.cc (right): http://codereview.chromium.org/3037052/diff/1/2#newcode496 chrome/browser/dom_ui/filebrowse_ui.cc:496: if (StartsWithASCII(url.spec(), std::string(kPicasawebUserPrefix), true)) { This isn't needed. ...

10 years, 4 months ago (2010-08-07 06:09:19 UTC) #2

viettrungluu

10 years, 4 months ago (2010-08-07 06:36:09 UTC) #3

Thanks!

http://codereview.chromium.org/3037052/diff/1/2
File chrome/browser/dom_ui/filebrowse_ui.cc (right):

http://codereview.chromium.org/3037052/diff/1/2#newcode496
chrome/browser/dom_ui/filebrowse_ui.cc:496: if (StartsWithASCII(url.spec(),
std::string(kPicasawebUserPrefix), true)) {
On 2010/08/07 06:09:19, Lei Zhang wrote:
> This isn't needed. You can pass a char[] in here.

Done.

Expand Messages | Collapse Messages

Issue 3037052: Convert browser/dom_ui/f*.cc to not use wstrings/wchar_t*s. (Closed)

Description

Patch Set 1 #

Patch Set 2 : changed per thestig #

Messages

Issue 3037052: Convert browser/dom_ui/f.cc to not use wstrings/wchar_ts. (Closed)