Issue 3037019: Fixing broken Integration tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3037019: Fixing broken Integration tests. (Closed)

Created:
10 years, 5 months ago by Raghu Simha

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.

Visibility:
Public.

Description

Fixing broken Integration tests. Several integration tests use the wrong method to wait for sync to complete, as a result of which they fail during verification. Also making the condition for the detection of sync completion more robust. BUG=50114 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53759

Patch Set 1 #

Patch Set 2 : Making sync constraints more robust. #

Patch Set 3 : Adding periods after comments. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -53 lines)			Patch
M	chrome/test/live_sync/live_sync_test.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/live_sync/profile_sync_service_test_harness.cc	View		3 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/test/live_sync/two_client_live_autofill_sync_test.cc	View		5 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc	View	1 2	21 chunks	+30 lines, -43 lines	0 comments	Download
M	chrome/test/live_sync/two_client_live_preferences_sync_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

LGTM (once the AwaitQuiescense patch is LGTM'd)

10 years, 5 months ago (2010-07-26 16:38:40 UTC) #2

Raghu Simha

10 years, 5 months ago (2010-07-27 02:03:15 UTC) #3

I've made a couple of minor changes to my original patch; sending this out in
case you'd like to take a look.

The trybots should cycle green soon. They didn't have the correct revision when
I first ran them, but they're looking fine now.

Expand Messages | Collapse Messages