Issue 3037008: Fix issue 785. For-in now works on strings: for (var i in "asdf") now works...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3037008: Fix issue 785. For-in now works on strings: for (var i in "asdf") now works... (Closed)

Created:
10 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix issue 785. For-in now works on strings: for (var i in "asdf") now works all the time, not just the first time it is run. Committed: http://code.google.com/p/v8/source/detail?r=5095

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -0 lines)			Patch
	M	src/handles.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	test/mjsunit/for-in-special-cases.js	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

10 years, 5 months ago (2010-07-19 12:28:30 UTC) #2

LGTM with nit

http://codereview.chromium.org/3037008/diff/1/3
File test/mjsunit/for-in-special-cases.js (right):

http://codereview.chromium.org/3037008/diff/1/3#newcode76
test/mjsunit/for-in-special-cases.js:76: // We do not assume that for_in
enumerates elements in order.
for_in -> for-in?

http://codereview.chromium.org/3037008/diff/1/3#newcode102
test/mjsunit/for-in-special-cases.js:102: // We do not assume that for_in
enumerates elements in order.
for_in -> for-in

http://codereview.chromium.org/3037008/diff/1/3#newcode118
test/mjsunit/for-in-special-cases.js:118: 
Remove blank lines?

Expand Messages | Collapse Messages