Issue 3037006: Let PaintAtAck send an int tag instead of the TransportDIB handle.

Issue 3037006: Let PaintAtAck send an int tag instead of the TransportDIB handle. (Closed)

Created:
10 years, 5 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Greg Spencer (Chromium), brettw, brettw at google

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Let PaintAtAck send an int tag instead of the TransportDIB handle. TransportDIB handles are file descriptors on mac, which are duped when sent over IPC. Hence, they change their value, and the handle that comes back over IPC is not the same that was originally sent -- so they can't be used as map keys. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52925

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 4

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -33 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_painting_observer.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_unittest.cc	View	3	2 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome/browser/tab_contents/thumbnail_generator.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/thumbnail_generator.cc	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1	2 chunks	+3 lines, -2 lines	4 comments	Download
M	chrome/renderer/render_widget.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/render_widget.cc	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw at google

LGTM with comment fixes. http://codereview.chromium.org/3037006/diff/8001/5008 File chrome/common/render_messages_internal.h (right): http://codereview.chromium.org/3037006/diff/8001/5008#newcode158 chrome/common/render_messages_internal.h:158: int /* tag */, Can ...

10 years, 5 months ago (2010-07-19 17:45:23 UTC) #2

Nico

10 years, 5 months ago (2010-07-19 18:48:29 UTC) #3

Thanks, submitting.

http://codereview.chromium.org/3037006/diff/8001/5008
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/3037006/diff/8001/5008#newcode158
chrome/common/render_messages_internal.h:158: int /* tag */,
On 2010/07/19 17:45:23, brettw at google wrote:
> Can you add to the comment for this message about what tag is and that it will
> be sent back with the ACK?

Done.

http://codereview.chromium.org/3037006/diff/8001/5008#newcode1127
chrome/common/render_messages_internal.h:1127: // processed, and the DIB is
ready for use.
On 2010/07/19 17:45:23, brettw at google wrote:
> Can you add here where tag comes from?

Done.

Expand Messages | Collapse Messages