Check ASCIIness of lhs, not this.

Check ASCIIness of lhs, not this.

In one pathalogical case it's possible to have this->IsAsciiRepresentation() &&
!this->TryFlattenGetString()->IsAsciiRepresentation()---if cons string has two byte
string which holds only ascii chars and second is an empty string.  In this case we
would return first which is not AsciiRepresentation(), however cons is.

Committed: http://code.google.com/p/v8/source/detail?r=5188

[antonm, 2010-08-05 16:23:21]

Vitaly,

may you have a look?

[Vitaly Repeshko, 2010-08-05 16:31:50]

LGTM!

Can we add a test for this? It should hit an assert in String::ToAsciiVector in
the case you describe.


Thanks,
Vitaly