Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: chrome/browser/automation/automation_resource_message_filter.h

Issue 3036038: ChromeFrame currently overrides the request context for intercepting network ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_resource_message_filter.h
===================================================================
--- chrome/browser/automation/automation_resource_message_filter.h (revision 54821)
+++ chrome/browser/automation/automation_resource_message_filter.h (working copy)
@@ -14,6 +14,7 @@
#include "base/platform_thread.h"
#include "ipc/ipc_channel_proxy.h"
#include "net/base/completion_callback.h"
+#include "net/base/cookie_store.h"
class URLRequestAutomationJob;
class GURL;
@@ -41,12 +42,23 @@
is_pending_render_view(pending_view) {
}
+ void set_cookie_store(net::CookieStore* cookie_store) {
+ cookie_store_ = cookie_store;
+ }
+
+ net::CookieStore* cookie_store() {
+ return cookie_store_.get();
+ }
+
int tab_handle;
int ref_count;
scoped_refptr<AutomationResourceMessageFilter> filter;
// Indicates whether network requests issued by this render view need to
// be executed later.
bool is_pending_render_view;
+
+ // The cookie store associated with this render view.
+ scoped_refptr<net::CookieStore> cookie_store_;
};
// Create the filter.
@@ -101,10 +113,14 @@
// Retrieves cookies for the url passed in from the external host. The
// callback passed in is notified on success or failure asynchronously.
- static void GetCookiesForUrl(int tab_handle, const GURL& url,
- net::CompletionCallback* callback,
- net::CookieStore* cookie_store);
+ // Returns true on success.
+ static bool GetCookiesForUrl(const GURL& url,
+ net::CompletionCallback* callback);
+ // Sets cookies on the URL in the external host. Returns true on success.
+ static bool SetCookiesForUrl(const GURL& url, const std::string& cookie_line,
+ net::CompletionCallback* callback);
+
// This function gets invoked when we receive a response from the external
// host for the cookie request sent in GetCookiesForUrl above. It sets the
// cookie temporarily on the cookie store and executes the completion
@@ -113,10 +129,6 @@
void OnGetCookiesHostResponse(int tab_handle, bool success, const GURL& url,
const std::string& cookies, int cookie_id);
- // Set cookies in the external host.
- static void SetCookiesForUrl(int tab_handle, const GURL&url,
- const std::string& cookie_line, net::CompletionCallback* callback);
-
protected:
// Retrieves the automation request id for the passed in chrome request
// id and returns it in the automation_request_id parameter.

Powered by Google App Engine
This is Rietveld 408576698