Issue 3036029: Add newline after CROS_WORKON_COMMIT="" line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3036029: Add newline after CROS_WORKON_COMMIT="" line. (Closed)

Created:
10 years, 4 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
adlr, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Add newline after CROS_WORKON_COMMIT="" line. Currently, cros_mark_as_stable.py does not add a newline after its CROS_WORKON_COMMIT="" line. This works fine for 9999 ebuilds that have a newline after the EAPI="" line, but doesn't work for ebuilds that don't do this. This should fix the preflight queue build. TEST=Ran cros_mark_as_stable.py on the update engine and verified that the CROS_WORKON_COMMIT="" line was not joined together with the next line. BUG=none

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cros_mark_as_stable.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 4 months ago (2010-07-30 18:53:24 UTC) #3

thanks for catching this david!

On Fri, Jul 30, 2010 at 7:55 AM,  <adlr@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/3036029/show
>

Expand Messages | Collapse Messages