Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 3036023: Revert 52613 - Revert 52608 - Add and alternative GetAppOutput() to process_u... (Closed)

Created:
10 years, 4 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 52613 - Revert 52608 - Add and alternative GetAppOutput() to process_util that takes a timeout. [Undoing the revert to see if the failure wasn't a flake.... Revert if the original failure, below, occurs again.] ["base_unittests" didn't exit cleanly on "Chromium Linux x64" but was killed due to timeout.] Contributed by tessamac@chromium.org TEST=none BUG=47356 Review URL: http://codereview.chromium.org/2810014 Patch from Tessa MacDuff <tessamac@chromium.org>;. TBR=viettrungluu@chromium.org, tessamac@chromium.org Review URL: http://codereview.chromium.org/3012004 TBR=viettrungluu@chromium.org, tessamac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -19 lines) Patch
M base/process_util.h View 2 chunks +12 lines, -0 lines 0 comments Download
M base/process_util_posix.cc View 6 chunks +55 lines, -11 lines 0 comments Download
M base/process_util_unittest.cc View 1 chunk +74 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
10 years, 4 months ago (2010-07-28 03:12:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698