Issue 3035053: Merge 54514 - Set a max limit on extension items' labels in context menus....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3035053: Merge 54514 - Set a max limit on extension items' labels in context menus.... (Closed)

Created:
10 years, 4 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/479/src/

Visibility:
Public.

Description

Merge 54514 - Set a max limit on extension items' labels in context menus. Also do some cleanup of context menu tests, including adding a generic mechanism to let javascript pass a test message and have C++ test code wait for and retrieve those messages. BUG=49744 TEST=Follow steps in bug report Review URL: http://codereview.chromium.org/3017047 TBR=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54955

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+246 lines, -91 lines)			Patch
M	chrome/browser/extensions/extension_context_menu_browsertest.cc	View	2 chunks	+158 lines, -48 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_menu_manager.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_menu_manager.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_test_api.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_test_api.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
A +	chrome/browser/extensions/extension_test_message_listener.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/extensions/extension_test_message_listener.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	4 chunks	+11 lines, -3 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/context_menus/long_title/background.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/context_menus/long_title/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/context_menus/long_title/test.js	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/context_menus/patterns/test.js	View	1 chunk	+1 line, -19 lines	0 comments	Download
M	chrome/test/data/extensions/context_menus/simple/test.js	View	1 chunk	+2 lines, -20 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages